Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/wallet: More reserved addresses aliases and checks #134

Merged
merged 1 commit into from
Jan 26, 2024
Merged

cmd/wallet: More reserved addresses aliases and checks #134

merged 1 commit into from
Jan 26, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Sep 25, 2023 •
edited
Loading

This PR:

  • Migrates ResolveAddress() from Oasis SDK to Oasis CLI
  • Adds literals for the pools and other reserved addresses into address resolving code
  • Documents the usage of pool: literal
  • Bumps usage of client-sdk/go to 0.7.2

Fixes oasisprotocol/oasis-sdk#1508

@matevz matevz changed the title cmd/wallet: More reserved addresses cmd/wallet: More reserved addresses checks Sep 25, 2023
@matevz matevz changed the title cmd/wallet: More reserved addresses checks cmd/wallet: More reserved addresses aliases and checks Sep 25, 2023
@matevz matevz force-pushed the matevz/feature/more-reserved-addresses branch from 0efb1fc to 68da05c Compare January 24, 2024 15:42
@matevz matevz mentioned this pull request Jan 24, 2024
Merged
@matevz matevz force-pushed the matevz/feature/more-reserved-addresses branch 3 times, most recently from c9816ce to 6ae2a28 Compare January 25, 2024 12:16
@matevz matevz marked this pull request as ready for review January 25, 2024 12:16
@matevz matevz requested a review from kostko January 25, 2024 12:16
kostko
kostko reviewed Jan 25, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
kostko
kostko reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be removed from the SDK?

Also could we have some tests for these, maybe just try to use them in account show?

@matevz
Copy link
Member Author

matevz commented Jan 25, 2024 •
edited
Loading

Will this be removed from the SDK?

Yes, see oasisprotocol/oasis-sdk#1614

@matevz matevz force-pushed the matevz/feature/more-reserved-addresses branch from 6ae2a28 to 11e24c6 Compare January 25, 2024 14:05
@matevz matevz mentioned this pull request Jan 25, 2024
Merged
@matevz matevz force-pushed the matevz/feature/more-reserved-addresses branch 6 times, most recently from af08a48 to f30a994 Compare January 26, 2024 11:57
@matevz matevz force-pushed the matevz/feature/more-reserved-addresses branch from f30a994 to 6763d65 Compare January 26, 2024 12:02
@matevz matevz merged commit 1b97709 into master Jan 26, 2024
3 checks passed
@matevz matevz deleted the matevz/feature/more-reserved-addresses branch January 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for consensus pool:common and pool:fee-accumulator
2 participants
@matevz @kostko